vtgateproxy v19 buildable and passing tests#594
Merged
dedelala merged 7 commits intovtgateproxy-v19from Feb 3, 2025
Merged
Conversation
Signed-off-by: Esme Lamb <dlamb@slack-corp.com>
Signed-off-by: Esme Lamb <dlamb@slack-corp.com>
Signed-off-by: Esme Lamb <dlamb@slack-corp.com>
demmer
reviewed
Jan 31, 2025
| if strings.HasPrefix(sql, "use ") { | ||
| targetString := sqlescape.UnescapeID(sql[4:]) | ||
| targetString, err := sqlescape.UnescapeID(sql[4:]) | ||
| if err != nil { |
There was a problem hiding this comment.
Somewhat minor question but actually a bit thought provoking as well...
Suppose this parsing fails for whatever reason. Is it better to fail (as you did here) or just fall through and call session.Execute below? Since the whole point of this use statement hijacking is to avoid a round trip, if for some rare reason vtgate is able to process it but the proxy isn't then could we be unnecesarily failing?
Then again maybe the case where we can't unescape an ID is rare enough that it's just plain irrelevant?
@henryr curious about your thoughts as well.
There was a problem hiding this comment.
I think it's ok to fail. I think it's just as likely that we create a dependency elsewhere in the proxy where we assume that we've always successfully intercepted use statements, as a situation arises where we can't unescape the argument.
dedelala
added a commit
that referenced
this pull request
Feb 7, 2025
* get v19 to build (WIP) * sort of builds? * misnamed flag * flag name * remove binary Signed-off-by: Esme Lamb <dlamb@slack-corp.com> * update go-mysql-driver Signed-off-by: Esme Lamb <dlamb@slack-corp.com> * return ErrNoSubConnAvailable for no available connections Signed-off-by: Esme Lamb <dlamb@slack-corp.com> --------- Signed-off-by: Esme Lamb <dlamb@slack-corp.com>
dedelala
added a commit
that referenced
this pull request
Apr 3, 2025
* get v19 to build (WIP) * sort of builds? * misnamed flag * flag name * remove binary Signed-off-by: Esme Lamb <dlamb@slack-corp.com> * update go-mysql-driver Signed-off-by: Esme Lamb <dlamb@slack-corp.com> * return ErrNoSubConnAvailable for no available connections Signed-off-by: Esme Lamb <dlamb@slack-corp.com> --------- Signed-off-by: Esme Lamb <dlamb@slack-corp.com>
dedelala
added a commit
that referenced
this pull request
Apr 3, 2025
* get v19 to build (WIP) * sort of builds? * misnamed flag * flag name * remove binary Signed-off-by: Esme Lamb <dlamb@slack-corp.com> * update go-mysql-driver Signed-off-by: Esme Lamb <dlamb@slack-corp.com> * return ErrNoSubConnAvailable for no available connections Signed-off-by: Esme Lamb <dlamb@slack-corp.com> --------- Signed-off-by: Esme Lamb <dlamb@slack-corp.com>
dedelala
added a commit
that referenced
this pull request
Apr 3, 2025
* get v19 to build (WIP) * sort of builds? * misnamed flag * flag name * remove binary Signed-off-by: Esme Lamb <dlamb@slack-corp.com> * update go-mysql-driver Signed-off-by: Esme Lamb <dlamb@slack-corp.com> * return ErrNoSubConnAvailable for no available connections Signed-off-by: Esme Lamb <dlamb@slack-corp.com> --------- Signed-off-by: Esme Lamb <dlamb@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
vtgateproxy-v19branch was created by cherry-picking the commits fromvtgateproxy-15onto the end ofslack-19.0vtgateproxybinary to build and pass e2e testschanges from 15 to 19 were more substantial than 14 to 15
mysql.Handlerinterfacemysql.NewListeneras flags with default valuessqlescape.UnescapeIDErrNoSubConnAvailableinstead of "no available connections" when first_ready builder is called with an empty map, this causes grpc to retry until a conn becomes ready. Otherwise fail fast logic is causing us to fail a bit too fast, something changed in this behaviour from grpc 1.45 (v15) to 1.62 (v19)